Patch existing entities in POST /bundle/import
#1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenchy64
force-pushed
the
patch-bundle-import
branch
from
ff76e29
to
2c33547
Compare
This reverts commit afc2391.
ereteog
approved these changes
Oct 11, 2023
| "foouser" | ||
| "foogroup" | ||
| "user") | ||
| (let [create-response (th/POST app |
There was a problem hiding this comment.
🟠 why did you need to use the http layer (+ authorization) instead of the existing bundle/import?
There was a problem hiding this comment.
I couldn't figure out how to make the test run on my machine.
Comment on lines
+125
to
+126
| (if (empty? asset_refs) | ||
| {} |
There was a problem hiding this comment.
I guess that's now it's already included in the first test of the loop, right?:
entities (loop [asset_refs asset_refs
entities {}]
(if (empty? asset_refs)
entitiesThere was a problem hiding this comment.
I just left it in to skip a useless log.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Epic https://github.com/advthreat/iroh/issues/7341
Related https://github.com/advthreat/iroh/issues/8207
Current behavior of bundle import on existing entities is to ignore them. This PR changes behavior to patch in this case, and loosens the schema for bundle import so then partial entities are allowed if patching.
§ QA
This PR adds the ability for
POST /bundle/importto patch entities. The following steps test if this procedure works.POST /bundle/import. For example, patching the:producerfield of the indicator:"updated"part is the most important part):GET /ctia/indicatorto verify that theproducerfield was updated.§ Release Notes
§ Squashed Commits